Migrate to pull-streams #20
Conversation
|
Ready for the first round of review, except for two tests all is green |
| var listener.listen(function ready () { | ||
| console.log('ready') | ||
| listener.listen(() => { | ||
| console.log('listening') |
There was a problem hiding this comment.
maybe as a debug log with more info?
There was a problem hiding this comment.
uups looks like I forgot some console.logs
There was a problem hiding this comment.
nvm this is the readme..
|
@dignifiedquire added documentation on why the pull-streams: if 👍, then lets add to all the PRs |
| const pullToStream = require('pull-stream-to-stream') | ||
|
|
||
| const nodeStreamInstance = pullToStream(pullStreamInstance) | ||
| // nodeStreamInstance is an istance of a Node.js Stream |
There was a problem hiding this comment.
instance not istance
|
Thanks @diasdavid. @RichardLitt would appreciate some review on the new documentation. |
| ``` | ||
|
|
||
| To learn more about his utility, visit https://pull-stream.github.io/#pull-stream-to-stream | ||
|
|
There was a problem hiding this comment.
@RichardLitt could you review this pull-streams segment. Thank you :)
|
Last things to do:
//cc @dignifiedquire |
daviddias
force-pushed
the
pull
branch
2 times, most recently
from
f856bf0 to
50abf8a
Compare
|
Only missing, passing interface-transport tests \o/ |
|
@diasdavid fixed in libp2p/interface-transport#10 |
netfrom node core for nowpull-netand use thatinterface-connection, the other needs some investigation.